Yangsx-1 commented on code in PR #1704:
URL: https://github.com/apache/kvrocks/pull/1704#discussion_r1306464435
##########
src/storage/redis_metadata.cc:
##########
@@ -378,7 +379,7 @@ rocksdb::Status StreamMetadata::Decode(const std::string
&bytes) {
GetFixed64(&input, &version);
GetFixedCommon(&input, &size);
- if (input.size() < 88) {
+ if (input.size() < 96) {
Review Comment:
Oh, i don't recognize it. The variable `group_number` is added to
`StreamMetadata` and it serves for quickly getting the consumer group number
which will be used in `XINFO STREAM`. I can delete it if necessary and the
number of consumer groups can be counted through iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
