PragmaTwice commented on code in PR #1704:
URL: https://github.com/apache/kvrocks/pull/1704#discussion_r1306468124
##########
src/storage/redis_metadata.cc:
##########
@@ -378,7 +379,7 @@ rocksdb::Status StreamMetadata::Decode(const std::string
&bytes) {
GetFixed64(&input, &version);
GetFixedCommon(&input, &size);
- if (input.size() < 88) {
+ if (input.size() < 96) {
Review Comment:
I mean, you can add some new field to StreamMetadata, but you cannot make
old data in user's storage inaccessible.
So if you want to add a new field, you need to consider to write a Decode
function that can work well while facing old userdata without the field you
just add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
