xq2010 commented on code in PR #1798:
URL: https://github.com/apache/kvrocks/pull/1798#discussion_r1356034349
##########
src/storage/rdb.h:
##########
@@ -47,26 +53,31 @@ constexpr const int RDBTypeZSetListPack = 17;
constexpr const int RDBTypeListQuickList2 = 18;
constexpr const int RDBTypeStreamListPack2 = 19;
constexpr const int RDBTypeSetListPack = 20;
-// NOTE: when adding new Redis object encoding type, update LoadObjectType.
+// NOTE: when adding new Redis object encoding type, update isObjectType.
// Quick list node encoding
constexpr const int QuickListNodeContainerPlain = 1;
constexpr const int QuickListNodeContainerPacked = 2;
+class RdbStream;
+
+using RedisObjValue =
+ std::variant<std::string, std::vector<std::string>,
std::vector<MemberScore>, std::map<std::string, std::string>>;
+
class RDB {
public:
- explicit RDB(engine::Storage *storage, std::string ns, std::string_view
input)
- : storage_(storage), ns_(std::move(ns)), input_(input){};
+ explicit RDB(engine::Storage *storage, Config *config, std::string ns,
std::shared_ptr<RdbStream> stream)
Review Comment:
The last commit has deleted the config parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
