xq2010 commented on code in PR #1798:
URL: https://github.com/apache/kvrocks/pull/1798#discussion_r1356053041
##########
src/commands/cmd_server.cc:
##########
@@ -1059,8 +1060,9 @@ class CommandRestore : public Commander {
ttl_ms_ -= now;
}
- RDB rdb(svr->storage, conn->GetNamespace(), args_[3]);
- auto s = rdb.Restore(args_[1], ttl_ms_);
+ auto stream_ptr = std::make_shared<RdbStringStream>(args_[3]);
Review Comment:
Yes, it's better to use unique_ptr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
