git-hulk commented on code in PR #1863:
URL: https://github.com/apache/kvrocks/pull/1863#discussion_r1381023447
##########
src/commands/blocking_commander.h:
##########
@@ -44,7 +44,6 @@ class BlockingCommander : public Commander,
// in other words, returning true indicates ending the blocking
virtual bool OnBlockingWrite() = 0;
- bool IsBlocking() const override { return true; }
Review Comment:
Yes, we don't migrate the connection once it has the running command to
avoid data race between the new and old worker. The data race condition was
mentioned in PR summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
