git-hulk commented on code in PR #1863:
URL: https://github.com/apache/kvrocks/pull/1863#discussion_r1382582778
##########
src/server/redis_connection.h:
##########
@@ -111,6 +111,7 @@ class Connection : public EvbufCallbackBase<Connection> {
Worker *Owner() { return owner_; }
void SetOwner(Worker *new_owner) { owner_ = new_owner; };
int GetFD() { return bufferevent_getfd(bev_); }
+ bool HasRunningCommand() const { return saved_current_command_ != nullptr; }
Review Comment:
Yes, I also misunderstood what you mean. You're right, it should only have
the data race in current_command, and the other variables should have the same
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
