PragmaTwice commented on code in PR #2015:
URL: https://github.com/apache/kvrocks/pull/2015#discussion_r1451662709
##########
src/storage/redis_metadata.cc:
##########
@@ -372,29 +372,31 @@ rocksdb::Status StreamMetadata::Decode(Slice *input) {
return s;
}
- if (input->size() < 8 * 11) {
- return rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
- }
+ if (Type() == kRedisStream) {
Review Comment:
It is already assumed that in `StreamMetadata::Decode` the type must be
kRedisStream, which should be checked in other places. So I don't think it is
meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
