jihuayu commented on code in PR #2015:
URL: https://github.com/apache/kvrocks/pull/2015#discussion_r1452168615
##########
src/storage/redis_metadata.cc:
##########
@@ -372,29 +372,31 @@ rocksdb::Status StreamMetadata::Decode(Slice *input) {
return s;
}
- if (input->size() < 8 * 11) {
- return rocksdb::Status::InvalidArgument(kErrMetadataTooShort);
- }
+ if (Type() == kRedisStream) {
Review Comment:
I am according to old code, maybe this code is unused now.
https://github.com/apache/kvrocks/blob/8d30e1eb2476f7c42d6c90f5cf112924e1d48ba9/src/storage/redis_metadata.cc#L338-L344
> I think a better way is to change `Metadata::ParseMetadata`.
Great, I will move all to `Metadata::ParseMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
