git-hulk commented on code in PR #2150:
URL: https://github.com/apache/kvrocks/pull/2150#discussion_r1519186644
##########
tests/gocase/unit/hello/hello_test.go:
##########
@@ -44,15 +44,19 @@ func TestHello(t *testing.T) {
t.Run("hello with protocol 2", func(t *testing.T) {
r := rdb.Do(ctx, "HELLO", "2")
rList := r.Val().([]interface{})
- require.EqualValues(t, rList[2], "proto")
- require.EqualValues(t, rList[3], 2)
+ require.EqualValues(t, "version", rList[2])
+ require.EqualValues(t, "4.0.0", rList[3])
+ require.EqualValues(t, "proto", rList[4])
+ require.EqualValues(t, 2, rList[5])
})
t.Run("hello with protocol 3", func(t *testing.T) {
r := rdb.Do(ctx, "HELLO", "3")
rList := r.Val().([]interface{})
- require.EqualValues(t, rList[2], "proto")
- require.EqualValues(t, rList[3], 2)
+ require.EqualValues(t, "version", rList[2])
+ require.EqualValues(t, "4.0.0", rList[3])
Review Comment:
@jihuayu Yes, but maybe we can update this when we decide to change the
Redis compatibility version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
