git-hulk commented on code in PR #2150:
URL: https://github.com/apache/kvrocks/pull/2150#discussion_r1519634020
##########
src/commands/cmd_server.cc:
##########
@@ -815,6 +818,11 @@ class CommandHello final : public Commander {
} else {
output_list.push_back(redis::BulkString("standalone"));
}
+ output_list.push_back(redis::BulkString("role"));
+ output_list.push_back(redis::BulkString(srv->IsSlave() ? "slave" :
"master"));
+ // For Kvrocks, the modules is not supported.
+ output_list.push_back(redis::BulkString("modules"));
+ output_list.push_back(conn->NilArray());
Review Comment:
@PragmaTwice Yes, we did support some modules like JSON, but the mechanism
is different from the Redis modules. For the Redis HELLO command, the module
field needs to return the module library path and integer version which NOT
exist in Kvrocks, so I kept this as an empty array.
```
1) 1# "name" => "ReJSON"
2# "ver" => (integer) 20606
3# "path" => "/opt/redis-stack/lib/rejson.so"
4# "args" => (empty array)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
