jihuayu commented on code in PR #2175:
URL: https://github.com/apache/kvrocks/pull/2175#discussion_r1527327009
##########
.github/workflows/kvrocks.yaml:
##########
@@ -298,6 +306,29 @@ jobs:
fi
./x.py test go build $GOCASE_RUN_ARGS ${{ matrix.ignore_when_tsan}}
+ - name: Install redis-py
+ run: pip3 install redis==4.3.6
+
+ - name: Run kvrocks2redis Test
+ if: ${{ !contains(matrix.name, 'Tsan') && !contains(matrix.name,
'Asan') && !startsWith(matrix.os, 'macos') }}
Review Comment:
Can you add the comment for this line?
##########
.github/workflows/kvrocks.yaml:
##########
@@ -256,7 +264,7 @@ jobs:
./x.py build -j$NPROC --unittest --compiler ${{ matrix.compiler }}
${{ matrix.without_jemalloc }} \
${{ matrix.without_luajit }} ${{ matrix.with_ninja }} ${{
matrix.with_sanitizer }} ${{ matrix.with_openssl }} \
${{ matrix.new_encoding }} ${{ matrix.with_speedb }} ${{
env.CMAKE_EXTRA_DEFS }}
-
+
Review Comment:
Don't change the blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
