PragmaTwice commented on code in PR #2175:
URL: https://github.com/apache/kvrocks/pull/2175#discussion_r1527392351
##########
utils/kvrocks2redis/tests/ci/kvrocks.conf:
##########
@@ -0,0 +1,914 @@
+################################ GENERAL #####################################
Review Comment:
As mentioned before, could you consider to remove this file?
##########
.github/workflows/kvrocks.yaml:
##########
@@ -298,6 +306,29 @@ jobs:
fi
./x.py test go build $GOCASE_RUN_ARGS ${{ matrix.ignore_when_tsan}}
+ - name: Install redis-py
+ run: pip3 install redis==4.3.6
+
+ - name: Run kvrocks2redis Test
+ if: ${{ !contains(matrix.name, 'Tsan') && !contains(matrix.name,
'Asan') && !startsWith(matrix.os, 'macos') }}
+ run: |
+ ulimit -c unlimited
+ export LSAN_OPTIONS="suppressions=$(realpath
./tests/lsan-suppressions)"
+ export TSAN_OPTIONS="suppressions=$(realpath
./tests/tsan-suppressions)"
+ $HOME/local/bin/redis-server --daemonize yes
+ mkdir -p data
+ echo "dir `pwd`/data" >> ./utils/kvrocks2redis/tests/ci/kvrocks.conf
+ echo "pidfile `pwd`/kvrocks.pid" >>
./utils/kvrocks2redis/tests/ci/kvrocks.conf
+ echo "data-dir `pwd`/data" >>
./utils/kvrocks2redis/tests/ci/kvrocks2redis.conf
+ ./build/kvrocks -c ./utils/kvrocks2redis/tests/ci/kvrocks.conf
Review Comment:
I don't think we need a new configuration file, e.g.
```
kvrocks --dir ... --pidfile ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
