git-hulk commented on PR #2182: URL: https://github.com/apache/kvrocks/pull/2182#issuecomment-2008638438
> > I wonder if we're being a little too radical in upgrading rocksdb. > > Just feeling "radical" is not a valid objection. > > Please attach detailed reason. The underlying storage may affect the performance and even break users' data, so we must take care while upgrading, especially for the major version. But the main issue is that except for the rocksdb release logs, we don't have other metrics to tell if we're good to upgrade. I suggest holding this change for a while and keeping an eye on the rocksdb community, and bringing this change after the next release if all goes well in the rocksdb community. It's good to introduce it in the unstable branch but exclude this change in the next release to make sure we have enough time to collect feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
