mapleFU commented on PR #2182: URL: https://github.com/apache/kvrocks/pull/2182#issuecomment-2009710990
Sigh, actually we're not that team which too familiar with RocksDB(and we don't has strictly performance requirement on it), this has a bad part and a good part. The bad part is mostly we don't know the risk of RocksDB's new version, Meta might rush tools for zippydb, myrocks or other internal user. The good part is, we just use some basic api in RocksDB, which would hardly trigger the "new bug" in RocksDB, its tests can cover our basic usages. So personally I think we can upgrade it, but all release notes should be review carefully, and maybe we can have a performance or other testing here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
