torwig commented on code in PR #2276:
URL: https://github.com/apache/kvrocks/pull/2276#discussion_r1582068743
##########
src/cluster/replication.h:
##########
@@ -98,7 +98,7 @@ class ReplicationThread : private
EventCallbackBase<ReplicationThread> {
Status Start(std::function<void()> &&pre_fullsync_cb, std::function<void()>
&&post_fullsync_cb);
void Stop();
ReplState State() { return repl_state_.load(std::memory_order_relaxed); }
- time_t LastIOTime() { return last_io_time_.load(std::memory_order_relaxed); }
+ time_t LastIOTime() { return
last_io_time_secs_.load(std::memory_order_relaxed); }
Review Comment:
Can we make `in64_t` as a return type here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
