mapleFU commented on code in PR #2276:
URL: https://github.com/apache/kvrocks/pull/2276#discussion_r1591308690
##########
src/server/server.h:
##########
@@ -355,9 +356,9 @@ class Server {
std::mutex db_job_mu_;
bool db_compacting_ = false;
bool is_bgsave_in_progress_ = false;
- int64_t last_bgsave_time_ = -1;
+ int64_t last_bgsave_time_in_secs_ = -1;
Review Comment:
Sigh, I think we can keep this, this is because:
```c++
string_stream << "last_bgsave_time:"
<< (last_bgsave_time_secs_ == -1 ? start_time_secs_ :
last_bgsave_time_secs_) << "\r\n";
string_stream << "last_bgsave_status:" << last_bgsave_status_ << "\r\n";
string_stream << "last_bgsave_time_sec:" << last_bgsave_time_spent_secs_
<< "\r\n";
```
Origin name has a "last_bgsave_time_sec" and "last_bgsave_time", I just want
to separate them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
