PragmaTwice commented on PR #2313:
URL: https://github.com/apache/kvrocks/pull/2313#issuecomment-2114992812
> > You can use the attribute `[[maybe_unused]]`.
>
> Wouldn't it be better to drop the unused parameter and keep the type only
>
> ```c
> virtual Status ToNumber(int64_t*) const { return {Status::NotOK, "not
supported"}; }
> virtual Status ToBool(bool*) const { return {Status::NotOK, "not
supported"}; }
> ```
There's some information in the name, so we'd better to keep them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
