mkmkme commented on code in PR #2313:
URL: https://github.com/apache/kvrocks/pull/2313#discussion_r1629972340
##########
CMakeLists.txt:
##########
@@ -273,6 +273,8 @@ else()
target_compile_definitions(kvrocks_objs PUBLIC METADATA_ENCODING_VERSION=0)
endif()
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror=unused-parameter")
Review Comment:
Setting `CMAKE_CXX_FLAGS` globally is an anti-pattern in CMake.
Maybe the same effect can be achieved with
```cmake
target_compile_options(kvrocks_objs PUBLIC -Werror=unused-parameter)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
