PokIsemaine commented on PR #2332: URL: https://github.com/apache/kvrocks/pull/2332#issuecomment-2212911927
NOTE: This is a relatively large PR that involves most of the functional modules. I tried to split them into smaller PRs but failed because the changes are interrelated and propagate among each other. Therefore, to better advance this work, I believe we need to conduct the review gradually and multiple times. At the start of each review, I will post a `"REVIEW X"` comment to inform which parts are being reviewed and highlight any points that need attention or discussion. When this review is complete, please reply to the comment with `"REVIEW X ok"` and I will start the next review. If you have any questions or suggestions during this period, please include the prefix `"REVIEW X"` to indicate which stage it belongs to. Although there are still some `TODO` items, I plan to discuss and refine them during the review process as you become more familiar with the background of these `TODOs`. If you think this approach is feasible, I will soon start the first review, change the PR from `Draft` to `Review` status, and then switch it back to Draft status for modifications. The overall process is: `REVIEW 1 => DRAFT modification => REVIEW 1 ok => REVIEW 2 => DRAFT modification => REVIEW 2 ok...`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
