PokIsemaine commented on PR #2332: URL: https://github.com/apache/kvrocks/pull/2332#issuecomment-2216327263
**REVIEW 1:** Notes: The main goal of `REVIEW 1` is to help everyone get familiar with the changes that have been made. These modifications will serve as a template for other parts, so I will select the core, stable, and simple parts to review. Before the review, please browse the previous explanations, comments, and related issues(https://github.com/apache/kvrocks/issues/2310). * Most APIs have been added with the `engine::Context` parameter. Please note the APIs that do not have this parameter added, as they may have been overlooked. * Many APIs originally had the `ReadOptions` parameter. Adding another `Context` parameter might overlap with `ReadOptions` in functionality, so consider whether these two parameters should be merged. For example, it might be necessary to use both the `batch` of `Context` and the complete `ReadOptions` settings (not just `Snapshot`). In order to understand everyone's thoughts, I have not modified it directly. If you think it should be merged, please provide suggestions. * Some APIs use `LatestSnapshot`, and it's necessary to consider whether this is mandatory. If not, consider using context directly to get the specified snapshot. I haven't modified it directly in order to understand what everyone thinks. If you think it should be replaced with `Context`, please provide suggestions. Files to review: ``` storage/storage.h storage/storage.cc storage/redis_db.h storage/redis_db.cc commands/cmd_string.cc types/redis_string.h types/redis_string.cc cppunit/test_base.h cppunit/types/string_test.cc ``` Currently, we haven't assigned reviewers for this PR. If it's convenient, I would like to kindly request @mapleFU , @git-hulk , and @PragmaTwice to assist with the review. I understand this may take some time, so please feel free to do it at your convenience. Your feedback and suggestions will be greatly appreciated. Thank you very much for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
