jjz921024 commented on code in PR #2402:
URL: https://github.com/apache/kvrocks/pull/2402#discussion_r1677886204


##########
src/storage/redis_metadata.h:
##########
@@ -203,6 +204,8 @@ class Metadata {
 class HashMetadata : public Metadata {
  public:
   explicit HashMetadata(bool generate_version = true) : Metadata(kRedisHash, 
generate_version) {}
+
+  bool IsEncodedFieldExpire() const;

Review Comment:
   I prefer `IsEncodedFieldHasTTL` because it has fewer letters than 
`IsEncodedFieldContainsTTL`  :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to