jjz921024 commented on PR #2402: URL: https://github.com/apache/kvrocks/pull/2402#issuecomment-2229887763
> > For all type, the first bit indicate use 64bit or 32bit encoding > > For hash type, the second bit of the flags to indicate whether encode the expiration into value (not affect for other types) > > No. It's too ad hoc and will introduce additional maintanance effort. (the encoding of HASH will be inconsistent with other types, which brings huge understanding, maintanance cost and additional code logic) > > And also, it breaks our whole design of "encoding version", e.g. HASH cannot have encoding version larger than 1. > > You can consider these options, as I mentioned before. > > > Instead, you can add a new enum value of data type, or add a new field in the metadata of hash. > > -1 for this change if no further commits. @PragmaTwice Hi, I fix it about `encoding version`. and add a new field in the metadata of hash to indicate whether the expiration time of field is encoded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
