jjz921024 commented on code in PR #2402:
URL: https://github.com/apache/kvrocks/pull/2402#discussion_r1682060470
##########
src/commands/cmd_hash.cc:
##########
@@ -429,6 +430,228 @@ class CommandHRandField : public Commander {
bool no_parameters_ = true;
};
+class CommandFieldExpireBase : public Commander {
+ protected:
+ Status commonParse(const std::vector<std::string> &args, int start_idx) {
+ int idx = start_idx;
+ CommandParser parser(args, idx);
+ std::string_view expire_flag, num_flag;
+ uint64_t fields_num = 0;
+ while (parser.Good()) {
+ if (parser.EatEqICaseFlag("FIELDS", num_flag)) {
+ fields_num = GET_OR_RET(parser.template TakeInt<uint64_t>());
+ idx += 2;
Review Comment:
Thank for you hint. I replace it with `parser.Remains()`, please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
