jjz921024 commented on code in PR #2402: URL: https://github.com/apache/kvrocks/pull/2402#discussion_r1682070867
########## src/types/redis_hash.cc: ########## @@ -418,4 +472,208 @@ rocksdb::Status Hash::RandField(const Slice &user_key, int64_t command_count, st return rocksdb::Status::OK(); } +rocksdb::Status Hash::ExpireFields(const Slice &user_key, uint64_t expire_ms, const std::vector<Slice> &fields, Review Comment: I tried the behavior on redis. Maybe we need to distinguish the `HEXPIREAT` with 0 and `HPERSIST`. For example: - ` HEXPIREAT k 0 FIELDS 1 f ` will return `2` (equivalent expire a pass time) - `HPERSIS k FIELDS 1 f` will return `1` (expiration was removed) So, we need a flag to distinguish them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
