PokIsemaine commented on code in PR #2332: URL: https://github.com/apache/kvrocks/pull/2332#discussion_r1685750463
########## src/search/indexer.cc: ########## @@ -275,17 +281,20 @@ Status IndexUpdater::UpdateHnswVectorIndex(std::string_view key, const kqir::Val auto storage = indexer->storage; auto hnsw = HnswIndex(search_key, vector, storage); + // TODO: ctx? Review Comment: There are instructions at the beginning of this PR > C. Description: This section is used to explain the modifications that you may feel strange > TODO: TODO: ctx in the implementation code means that I am not sure whether the ctx setting here is correct. Should it come from the upper parameters or create a Context myself? Where is the boundary of the Context. I'm not familiar with the search, slot, etc. parts yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
