PokIsemaine commented on code in PR #2332: URL: https://github.com/apache/kvrocks/pull/2332#discussion_r1685751383
########## src/search/indexer.cc: ########## @@ -275,17 +281,20 @@ Status IndexUpdater::UpdateHnswVectorIndex(std::string_view key, const kqir::Val auto storage = indexer->storage; auto hnsw = HnswIndex(search_key, vector, storage); + // TODO: ctx? Review Comment: I personally plan to discuss these TODOs when reviewing the corresponding parts. Of course, you can also give some suggestions and opinions by the way, but in this way I am not arbitrarily sure of the progress of your review and whether to enter the next stage of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
