torwig commented on code in PR #2506: URL: https://github.com/apache/kvrocks/pull/2506#discussion_r1730329198
########## kvrocks.conf: ########## @@ -335,6 +335,10 @@ json-max-nesting-depth 1024 # Default: json json-storage-format json +# Whether to enable transactional mode engine::Context. Review Comment: @PokIsemaine Two points: 1. Users usually don't read the source code so we need to explain them in the config file or other docs. The key question for users is "What benefit do I gain if I enable the feature?" 2. IMHO, if the feature **is** experimental. it should **not** be enabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
