PragmaTwice commented on code in PR #2506:
URL: https://github.com/apache/kvrocks/pull/2506#discussion_r1732014077


##########
kvrocks.conf:
##########
@@ -335,6 +335,20 @@ json-max-nesting-depth 1024
 # Default: json
 json-storage-format json
 
+# Whether to enable transactional mode engine::Context.
+#
+# If enabled, is_txn_mode in engine::Context will be set properly,
+# which is expected to improve the consistency of commands.
+# If disabled, is_txn_mode in engine::Context will be set to false,
+# making engine::Context equivalent to engine::Storage.
+#
+# NOTE: This is an experimental feature. If you find errors, performance 
degradation,
+# excessive memory usage, excessive disk I/O, etc. after enabling it, please 
try disabling it.
+# At the same time, we welcome feedback on related issues to help iterative 
improvements.
+# 
+# Default: no
+txn-context-enabled no

Review Comment:
   You can just change the go cases to make some test functions like `TestXX` 
work on both mode, e.g.
   ```
   TestXXAllMode() {
     TestXX(yes)
     TestXX(no)
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to