AntiTopQuark commented on code in PR #2498:
URL: https://github.com/apache/kvrocks/pull/2498#discussion_r1730751617
##########
src/server/worker.cc:
##########
@@ -446,6 +452,13 @@ Status Worker::Reply(int fd, const std::string &reply) {
auto iter = conns_.find(fd);
if (iter != conns_.end()) {
iter->second->SetLastInteraction();
+ if (iter->second->CheckClientReachOBufLimits(reply.size() +
evbuffer_get_length(iter->second->Output()))) {
Review Comment:
There are many commands that return results by using the `operator+= `
operation on the output string. Are you suggesting that every time `operator+=`
is used, we should monitor and check the memory usage? Wouldn't this cause
significant performance issues? Is it acceptable to make extensive changes to
the code related to many commands?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
