git-hulk commented on PR #2498: URL: https://github.com/apache/kvrocks/pull/2498#issuecomment-2311996885
To be honest, I'm worried about the performance and maintenance burden of this implementation. Maybe we should separate it into following PRs to make it easier to merge and review: - Allow to control the maximum size of the write batch - Allow to control the maximum size of connection input/output buffer(just check the size of libevent buffer) - Allow to control the maximum size of all clients(need a clear implementation proposal first) What do you think? @torwig @caipengbo @mapleFU @PragmaTwice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
