AntiTopQuark commented on code in PR #2508:
URL: https://github.com/apache/kvrocks/pull/2508#discussion_r1736446585
##########
src/search/indexer.cc:
##########
@@ -226,13 +226,19 @@ Status IndexUpdater::UpdateTagIndex(engine::Context &ctx,
std::string_view key,
for (const auto &tag : tags_to_delete) {
auto index_key = search_key.ConstructTagFieldData(tag, key);
- batch->Delete(cf_handle, index_key);
+ auto rocker_status = batch->Delete(cf_handle, index_key);
Review Comment:
done
##########
src/search/indexer.cc:
##########
@@ -226,13 +226,19 @@ Status IndexUpdater::UpdateTagIndex(engine::Context &ctx,
std::string_view key,
for (const auto &tag : tags_to_delete) {
auto index_key = search_key.ConstructTagFieldData(tag, key);
- batch->Delete(cf_handle, index_key);
+ auto rocker_status = batch->Delete(cf_handle, index_key);
+ if (!rocker_status.ok()) {
+ return {Status::NotOK, rocker_status.ToString()};
+ }
}
for (const auto &tag : tags_to_add) {
auto index_key = search_key.ConstructTagFieldData(tag, key);
- batch->Put(cf_handle, index_key, Slice());
+ auto rocker_status = batch->Put(cf_handle, index_key, Slice());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
