mapleFU commented on code in PR #2508: URL: https://github.com/apache/kvrocks/pull/2508#discussion_r1741465787
########## src/search/hnsw_indexer.cc: ########## @@ -93,7 +103,10 @@ Status HnswNode::RemoveNeighbour(engine::Context& ctx, const NodeKey& neighbour_ HnswNodeFieldMetadata node_metadata = GET_OR_RET(DecodeMetadata(ctx, search_key)); node_metadata.num_neighbours--; - PutMetadata(&node_metadata, search_key, ctx.storage, batch); + auto redis_status = PutMetadata(&node_metadata, search_key, ctx.storage, batch); Review Comment: RETURN_NOT_OK or just return this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
