jonathanc-n commented on code in PR #2524:
URL: https://github.com/apache/kvrocks/pull/2524#discussion_r1759624118
##########
src/storage/redis_metadata.cc:
##########
@@ -329,7 +329,8 @@ bool Metadata::ExpireAt(uint64_t expired_ts) const {
bool Metadata::IsSingleKVType() const { return Type() == kRedisString ||
Type() == kRedisJson; }
bool Metadata::IsEmptyableType() const {
- return IsSingleKVType() || Type() == kRedisStream || Type() ==
kRedisBloomFilter || Type() == kRedisHyperLogLog;
+ return IsSingleKVType() || Type() == kRedisStream || Type() ==
kRedisBloomFilter || Type() == kRedisHyperLogLog ||
Review Comment:
Oh, sorry about that, i was thinking due to the different variables, that it
would be instead put under emptyable type. But after review it makes more sense
as a singlekvtype
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
