PragmaTwice commented on code in PR #2524:
URL: https://github.com/apache/kvrocks/pull/2524#discussion_r1768548767
##########
src/storage/redis_metadata.h:
##########
@@ -335,3 +336,15 @@ class HyperLogLogMetadata : public Metadata {
EncodeType encode_type = EncodeType::DENSE;
};
+
+class CountMinSketchMetadata : public Metadata {
+ public:
+ uint32_t width;
+ uint32_t depth;
+ uint64_t counter = 0;
+ std::vector<uint32_t> array;
Review Comment:
But here I'm more interested in whether it's better to be a single key or
putting the array in subkeys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
