RiversJin commented on code in PR #2627:
URL: https://github.com/apache/kvrocks/pull/2627#discussion_r1819966288
##########
src/server/redis_reply.cc:
##########
@@ -37,9 +37,23 @@ namespace redis {
void Reply(evbuffer *output, const std::string &data) { evbuffer_add(output,
data.c_str(), data.length()); }
-std::string SimpleString(const std::string &data) { return "+" + data + CRLF; }
+std::string SimpleString(const std::string &data) {
Review Comment:
Of course! In fact, I would really like to switch to using std::string_view
as the parameter type. However, I saw that const string& is widely used in the
code, so I assumed it was a stylistic choice and didn't make the change. If
using the former is acceptable, I’ll make the adjustment later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
