mapleFU commented on code in PR #2627:
URL: https://github.com/apache/kvrocks/pull/2627#discussion_r1820038751
##########
src/server/redis_reply.cc:
##########
@@ -37,9 +37,23 @@ namespace redis {
void Reply(evbuffer *output, const std::string &data) { evbuffer_add(output,
data.c_str(), data.length()); }
-std::string SimpleString(const std::string &data) { return "+" + data + CRLF; }
+std::string SimpleString(const std::string &data) {
Review Comment:
> However, previously I was considering to introduce "rope" (a data
structure) to build `concat`ed strings in a relatively cheaper way, but it may
require many non-trivial work.
It's ok for some network buffer but would be to complex for `SimpleString`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
