RiversJin commented on PR #2627: URL: https://github.com/apache/kvrocks/pull/2627#issuecomment-2443917043
> Would you mind fix the lint? Sure but ... From the logs, this is not just a lint issue, but rather due to setting RESP_OK as the type std::string_view. Some function parameters accept const string& instead of std::string_view. If we change everything to accept std::string_view, I think it might require significant modifications... Since std::string_view cannot be implicitly converted to std::string, and I want to implement RESP_OK as a constexpr variable, I changed it to use constexpr char[]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
