git-hulk commented on PR #240: URL: https://github.com/apache/kvrocks-controller/pull/240#issuecomment-2567757749
@borismartinovic01 Thanks for your contribution. The CI failed due to forgetting to add `github.com/hashicorp/consul/api` into go.mod. You might need to add the `consul` to `scripts/docker/docker-compose.yml` to make the test work. Another concern is `consul`[1] is licensed under `MPL 2.0` which is a weak copyleft category[2] in ASF. We need to investigate what should be done before introducing it into our release. [1] https://github.com/hashicorp/consul?tab=License-1-ov-file#readme [2] https://www.apache.org/legal/resolved.html#weak-copyleft-licenses -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
