PragmaTwice commented on PR #240: URL: https://github.com/apache/kvrocks-controller/pull/240#issuecomment-2567972279
Yeah it seems https://github.com/hashicorp/consul is licensed under BSL, which is not an open-source license and not allowed by ASF to be used as a direct dependency of an ASF project. However, I think there may be several ways to workaround it: - Replace `github.com/hashicorp/consul/api` with another project which is under a compatible license. (maybe you need to check the license of other newly-introduced projects, too), or implement a simple client by our own. (I'm not familiar with this project so I don't know how much work it will be. From its docs [here](https://developer.hashicorp.com/consul/api-docs?product_intent=consul), it should not be impossible since it's HTTP-based. Note that we just need the consul client to be license-compatible. ) - Make this feature **totally** optional, and disable by default. In this way, it might be compliant, from the perspective of the ASF view. Note that, it means that the official release should not include this feature, and all code of these dependencies should not be compiled into the released binary. I'm not an expert in this area. See if @tisonkun has any comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
