jjz921024 commented on PR #2402: URL: https://github.com/apache/kvrocks/pull/2402#issuecomment-2585212962
@git-hulk @ltagliamonte Hi, I don't know how to commit code on the new pr #2717 , so I just keep working here. For the first point you mentioned on https://github.com/apache/kvrocks/pull/2717#issuecomment-2585068688, I had finish. please review. And the second point, do you mean that the `ExistValidField()` function should contain the following code? This code is repeated many times. I think the `ExistValidField()` is a dedicated function to check if it has any valid fields. ``` HashMetadata hash_metadata(false); s = hash_metadata.Decode(rocksdb::Slice(pin_values[i].data(), pin_values[i].size())); if (!s.ok()) continue; redis::Hash hash_db(storage_, namespace_); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
