aleksraiden commented on PR #2402: URL: https://github.com/apache/kvrocks/pull/2402#issuecomment-2585236933
> > Awesome work, @jjz921024 > > Maybe we need some benchmark - before include this feature and after? Тo test the impact of new logic on basic HSET's command (and prevent or minimize it)? > > @aleksraiden Hi, After optimization of [473db0c](https://github.com/apache/kvrocks/commit/473db0c9ec5cf9f38379eda0d11f01e61ba5f90a), the expire fields should have no effect on HSET command. Should we add some bench test for read command of hash type (like hgetall)? I have a test by standard redis-bench yesterday (before your commit) - and at quick look is there NO any impact to performance. But standard test looks only to GET/HSET as I see. Great job! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
