git-hulk commented on code in PR #2815:
URL: https://github.com/apache/kvrocks/pull/2815#discussion_r1981382848
##########
src/server/server.cc:
##########
@@ -853,6 +840,19 @@ void Server::cron() {
CleanupExitedSlaves();
recordInstantaneousMetrics();
}
+
+ assert(stop_);
Review Comment:
That's weird to move those codes from `Stop()` to `cron()`. I suspect the
issue was caused by the server being stopped before the replication was started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
