git-hulk commented on code in PR #2815:
URL: https://github.com/apache/kvrocks/pull/2815#discussion_r1982609195
##########
src/server/server.cc:
##########
@@ -853,6 +840,19 @@ void Server::cron() {
CleanupExitedSlaves();
recordInstantaneousMetrics();
}
+
+ assert(stop_);
Review Comment:
> 3952 (the repl thread) receive the signal -> call Server::Stop() -> join
itself.
The repl thread won't receive the terminated signal and stop the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
