SharonIV0x86 commented on PR #287: URL: https://github.com/apache/kvrocks-controller/pull/287#issuecomment-2742377901
@shubham-j-sde Thanks for your contribution. The existing codebase primarily uses JSX, while your files are in TSX. Although TSX is more modern and type-safe, for the scope of this PR, you can either convert your files to JSX for consistency or keep them as TSX. That said, quite possible in future we might consider migrating the project from JSX to TSX, so keeping your files in TSX could be beneficial. Its just a suggestion, you can proceed however you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
