baobaomaomeng commented on PR #2839: URL: https://github.com/apache/kvrocks/pull/2839#issuecomment-2742753312
> > Seems that this command is implemented as scan and MDel? > > I'm not sure should `deleterange` supports prefix delete ( which could implemented with the help of `rocksdb::DeleteRange` ) or a scan and delete script like this? @git-hulk @PragmaTwice @ShooterIT > > From my side, I think the prefix deletion could be a part of this command and we should use `rocksdb::DeleteRange` to avoid the performance issue if possible. > > And for the `DeleteRange` command, I have one question: is it good to support the `TYPE` option? which might heavily affect the performance since it needs to scan and retrieve the metadata. may be we need two commands,deletepattern and deleterange,the range delete.Handling special operations for range deletion in regular expressions is overly challenging. Additionally, the 'type' is decoded from iter->value(), and I don't quite understand why it requires scanning metadata when the entire implementation seems to be just a combination of scan + mdel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
