mapleFU commented on code in PR #2839:
URL: https://github.com/apache/kvrocks/pull/2839#discussion_r2018826989
##########
src/commands/cmd_key.cc:
##########
@@ -595,6 +623,7 @@ REDIS_REGISTER_COMMANDS(Key, MakeCmdAttr<CommandTTL>("ttl",
2, "read-only", 1, 1
MakeCmdAttr<CommandPExpireTime>("pexpiretime", 2,
"read-only", 1, 1, 1),
MakeCmdAttr<CommandDel>("del", -2, "write
no-dbsize-check", 1, -1, 1),
MakeCmdAttr<CommandDel>("unlink", -2, "write
no-dbsize-check", 1, -1, 1),
+ MakeCmdAttr<CommandDeleteRange>("deleterange", -2,
"write no-dbsize-check", 1, -1, 1),
Review Comment:
At least, a basic command might need to acquire the key lock, and further
more, the deleteRange should be exclusive since it doesn't acquire any keylock
when scanning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
