PragmaTwice commented on PR #2845: URL: https://github.com/apache/kvrocks/pull/2845#issuecomment-2756343357
The function itself looks good to me. Could you make the implementation more generic? I think in Kvrocks we want a good, complete and well-thought-out implementation instead of "oh, I wrote some code and it seems to work well in my case." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
