git-hulk commented on PR #2845: URL: https://github.com/apache/kvrocks/pull/2845#issuecomment-2763071188
> > > > @ltagliamonte How could we generate the SST if we would like to use this command? I raise this question because I prefer using the same rocksdb version instead of introducing gorocksdb. So I'm wondering if we should support generating SSTs first by providing a subcommand for Kvrocks. > > > > cc @apache/kvrocks-committers > > > > > > > > > Hello @git-hulk in this codebase the use of the gorocksdb library has been introduced just for the unit tests. I thought about just dropping few pre generated SST files but I didn't think it was the right approach. I also think that by looking at the unit test code I've added it's going to be extremely simple for any other programming language to generate correct SST files. > > > > > > @ltagliamonte-dd Yes, I know the gorocksdb is only for test purposes. I see you put a lot of effort into making the CI pass and generating SSTs, which is also a key step for using this command. So I think if we could provide the tool first and reuse this in our test cases. > > @git-hulk what kind of tool do you envision? we can think of adding some tooling in a later pr, it's a good idea but it shouldn't block this one wdyt? Yes, it won't block this PR. I intend to avoid putting a lot of time into making the CI correct by first building the SSTs tool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
