PragmaTwice commented on code in PR #2863:
URL: https://github.com/apache/kvrocks/pull/2863#discussion_r2024261060
##########
src/commands/cmd_server.cc:
##########
@@ -1410,5 +1555,6 @@ REDIS_REGISTER_COMMANDS(Server,
MakeCmdAttr<CommandAuth>("auth", 2, "read-only o
MakeCmdAttr<CommandReset>("reset", 1, "ok-loading
bypass-multi no-script", NO_KEY),
MakeCmdAttr<CommandApplyBatch>("applybatch", -2,
"write no-multi", NO_KEY),
MakeCmdAttr<CommandDump>("dump", 2, "read-only", 1, 1,
1),
- MakeCmdAttr<CommandPollUpdates>("pollupdates", -2,
"read-only admin", NO_KEY), )
+ MakeCmdAttr<CommandPollUpdates>("pollupdates", -2,
"read-only admin", NO_KEY),
+ MakeCmdAttr<CommandMigrate>("migrate", -6, "write", 1,
-1, 1))
Review Comment:
`1, -1, 1` means that all arguments are keys, which is obviously not correct
here.
You can refer to here for how to generate dynamic key ranges:
https://github.com/apache/kvrocks/blob/unstable/src/commands/cmd_zset.cc#L1552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
