PragmaTwice commented on code in PR #2863:
URL: https://github.com/apache/kvrocks/pull/2863#discussion_r2024209153
##########
src/commands/cmd_server.cc:
##########
@@ -1257,8 +1258,17 @@ class CommandDump : public Commander {
return Status::OK();
}
+ std::string dump_result;
+ auto s = DumpKey(ctx, srv, conn, key, dump_result);
+ if (!s.IsOK()) return s;
+ *output = redis::BulkString(dump_result);
+ return Status::OK();
+ }
+ static Status DumpKey(engine::Context &ctx, Server *srv, Connection *conn,
std::string &key,
+ std::string &dump_result) {
Review Comment:
I mean we can use `StatusOr` here instead of `Status`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
